Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show quote posts #4865

Merged
merged 16 commits into from
Aug 21, 2024
Merged

Show quote posts #4865

merged 16 commits into from
Aug 21, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Aug 1, 2024

dependant on bluesky-social/atproto#2658

Screenshot 1 Screenshot 2
Screenshot 2024-08-01 at 11 27 02 Screenshot 2024-08-01 at 11 27 09

@render Render
Copy link

render bot commented Aug 1, 2024

Your Render PR Server URL is https://social-app-pr-4865.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cqllbrbv2p9s73efpimg.

@mozzius mozzius marked this pull request as draft August 1, 2024 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Old size New size Diff
7.1 MB 7.1 MB 10.04 KB (0.14%)

@mozzius mozzius force-pushed the samuel/show-quotes branch from 093f27b to 628145e Compare August 2, 2024 21:58
@mozzius mozzius requested a review from haileyok August 2, 2024 22:26
@mozzius
Copy link
Member Author

mozzius commented Aug 2, 2024

@haileyok I moved the PostLikedBy and PostRepostedBy screens over to the new screens folder, I think we should do that whenever we successfully ALF a screen

@haileyok
Copy link
Contributor

haileyok commented Aug 2, 2024

image

@haileyok haileyok marked this pull request as ready for review August 19, 2024 19:48
haileyok
haileyok approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work! I added two things as well:

  • findAllPostsInQueryData for the queueLike/queueRepost shadows (so the like count will update when viewing a list of quotes)
  • Call onPost in the composer whenever the app view is ready (after the quote count changes from the original count). Makes it feel a little more responsive when on the post thread.

@estrattonbailey estrattonbailey merged commit 56ab5e1 into main Aug 21, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Aug 21, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into reply-qp-moderation
d579473 
* origin/main:
  Show quote posts (#4865)
  Fix hidden list for author (#4968)
  Update joined stat (#4967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozzius @haileyok @estrattonbailey