Change size #4957
Change size #4957
Conversation
|
Your Render PR Server URL is https://social-app-pr-4957.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr1mnfrgbbvc73f4oqp0. |
|
haileyok
force-pushed
the
hailey/tweak-max-size
branch
from
1ee8e91 to
ba6b2c2
Compare
haileyok
force-pushed
the
hailey/tweak-max-size
branch
from
f78b71d to
62519f7
Compare
| const {currentAccount} = useSession() | ||
| const {data, refetch, isError} = useListMembersQuery(listUri, 50) | ||
| const {data, refetch, isError} = useAllListMembersQuery(listUri) |
There was a problem hiding this comment.
not using pagination because we need to be able to reverse the entire set of profiles
| } catch (e) { | ||
| setIsProcessing(false) | ||
| Toast.show(_(msg`An error occurred while trying to follow all`), 'xmark') | ||
| logger.error('Failed to get list members for starter pack', { |
There was a problem hiding this comment.
This toast seems to refer to a different error? 🤔
There was a problem hiding this comment.
This is all part of the same Follow all action for the user. We just want to log a different error message to Sentry. (User doesn't need to know the difference here)
There was a problem hiding this comment.
all good, appreciate you looking over it!! ❤️
| @@ -73,7 +74,7 @@ function reducer(state: State, action: Action): State { | |||
| updatedState = {...state, description: action.description} | |||
| break | |||
| case 'AddProfile': | |||
| if (state.profiles.length >= 51) { | |||
| if (state.profiles.length > STARTER_PACK_MAX_SIZE) { | |||
| Toast.show( | |||
| msg`You may only add up to 50 profiles`.message ?? '', | |||
There was a problem hiding this comment.
Would it be feasible to amend this toast to refer to the STARTER_PACK_MAX_SIZE?
| if (state.feeds.length >= 3) { | ||
| Toast.show(msg`You may only add up to 3 feeds`.message ?? '', 'info') |
There was a problem hiding this comment.
This was wrong...fixed it
No description provided.