Make settings account buttons a little nicer #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4980.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr3sqfij1k6c73e1fmq0. |
haileyok
approved these changes
Aug 22, 2024
|
|
One other small thing I initially missed. I think it's a little weird that i get this flash if i scroll in the right area of the list (when leaving the main link and entering the ... button. Maybe we just use the old link (no hover effect)? Screen.Recording.2024-08-22.at.5.46.31.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the main line item wrapper with our new interactive elements, and replaces the ... menu with
Menuand a larger click target. So we get nice hover/pressed states.After:
Before
