Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Captions and alt text #5009

Merged
merged 13 commits into from
Aug 30, 2024
Merged

[Video] Captions and alt text #5009

merged 13 commits into from
Aug 30, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Aug 28, 2024

Stacked on #4881 and #4884

Alt text and caption dialog. Captions are only available on web. Max 4 languages.

Web composer Web dialog open Web with captions
Screenshot 2024-08-28 at 17 05 00 Screenshot 2024-08-28 at 17 05 48 Screenshot 2024-08-28 at 17 10 41
iOS composer iOS dialog open
Simulator Screenshot - iPhone 15 - 2024-08-28 at 17 11 53 Simulator Screenshot - iPhone 15 - 2024-08-28 at 17 11 58

@mozzius mozzius requested a review from haileyok August 28, 2024 16:47
Copy link

render bot commented Aug 28, 2024

@mozzius mozzius changed the base branch from main to samuel/video-uploads-fr-this-time August 28, 2024 16:52
@mozzius
Copy link
Member Author

mozzius commented Aug 28, 2024

Oh, you might see languages with <Name> ( ) - this is related to the language cleanup PR from earlier

@mozzius mozzius force-pushed the samuel/video-uploads-fr-this-time branch from 3ff95a1 to b47c6da Compare August 29, 2024 11:26
@mozzius mozzius force-pushed the samuel/video-alt-subtitles branch 2 times, most recently from 758cdb7 to 8ff4ce8 Compare August 29, 2024 13:24
Copy link

github-actions bot commented Aug 29, 2024

Old size New size Diff
7.07 MB 7.08 MB 8.68 KB (0.12%)

@mozzius mozzius force-pushed the samuel/video-uploads-fr-this-time branch from 31b4218 to 0d4d418 Compare August 29, 2024 15:16
Base automatically changed from samuel/video-uploads-fr-this-time to main August 29, 2024 15:38
@mozzius mozzius force-pushed the samuel/video-alt-subtitles branch from a010e59 to e525bea Compare August 29, 2024 15:43
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks good. Didn't test with a VTT file but the dialog seems to work, properly shows available options on web/native, etc. Great!!

src/view/com/composer/videos/SubtitleDialog.tsx Outdated Show resolved Hide resolved
src/view/com/composer/videos/SubtitleDialog.tsx Outdated Show resolved Hide resolved
@mozzius mozzius force-pushed the samuel/video-alt-subtitles branch from 76e2702 to 9a41562 Compare August 30, 2024 13:58
@mozzius mozzius merged commit c70ec1c into main Aug 30, 2024
6 checks passed
@mozzius mozzius deleted the samuel/video-alt-subtitles branch August 30, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants