Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Lexicon implementation #4881

Merged
merged 10 commits into from
Aug 29, 2024
Merged

[Video] Lexicon implementation #4881

merged 10 commits into from
Aug 29, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Aug 6, 2024

Stacked on #4732

Adapts the video player to use the AppBskyEmbedVideo lexicon, including aspect ratios and alt text

Copy link

render bot commented Aug 6, 2024

Copy link

github-actions bot commented Aug 6, 2024

Old size New size Diff
7.51 MB 7.15 MB -373.07 KB (-4.85%)

@mozzius mozzius changed the title [Video] Lexicon implementation in player [Video] Lexicon implementation Aug 6, 2024
@haileyok haileyok changed the base branch from main to samuel/videos-web August 7, 2024 15:54
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from samuel/videos-web to main August 7, 2024 19:07
@mozzius mozzius force-pushed the samuel/video-lex branch 2 times, most recently from af845fc to d55faaa Compare August 13, 2024 15:12
@mozzius mozzius force-pushed the samuel/video-lex branch 3 times, most recently from 42c4fb4 to 275a02f Compare August 23, 2024 21:10
@mozzius mozzius requested a review from haileyok August 29, 2024 11:20
@mozzius mozzius merged commit d92731b into main Aug 29, 2024
6 checks passed
@mozzius mozzius deleted the samuel/video-lex branch August 29, 2024 14:58
estrattonbailey added a commit that referenced this pull request Aug 29, 2024
* origin/main: (520 commits)
  Fix language filtering for feeds (#5026)
  Enable show_follow_back_label_v2 (#5022)
  Remove logging of following prefs (#5021)
  Remove new_user_guided_tour and tour code (#5023)
  [Video] Remove old env var (#5018)
  Profile screen performance tweak - Adjust initial num to render based on header height (#5005)
  [Video] Make compress/upload cancelable (#4996)
  [Video] Add uploaded video to post (#4884)
  [Video] Add `timeRemainingChange` event to `player` in `expo-video` (#5013)
  [Video] Lexicon implementation (#4881)
  Hide quote counts for quotegated posts (#5011)
  Ensure captcha verification code gets submitted in signup request (#5010)
  clean up languages (#5007)
  [Video] 🫧 Move logic around by platform (#5003)
  bump 1.91.0 (#5002)
  add indicator of time remaining (#5000)
  [Video] add scrubber to the web player (#4943)
  Release 1.90 prep (#4988)
  Use moderatePost_wrapped for post embeds (#4981)
  Update Indonesian translation (#4875)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants