[Experiment] Suggest profiles in profile #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5030.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr8hogrtq21c7399r9l0. |
|
haileyok
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Rename variable to disambiguate with parent scope * More variables where they are used * Inline variables * Add suggestions in profile * Gate it * rm space * Remove header suggestions under gate (cherry picked from commit dbbbba1)
|
Hi! Providing some feedback: I hate this, I do not like having my timeline split with a carousel of random accounts. Please take this out of the app 👍 |
|
There's a new feedback thread in #5214, would appreciate specific feedback there! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more prominent placement for the profile suggestions since they've gotten better recently. This adds an interstitial to profile feeds (Posts and Replies tabs only).
Test Plan
Enable the gate. Observe this block after 5 slices:
It should be profile-dependent. Check with different profiles. (Might work better with a fresh account if your cluster follows are already saturated.) Some profiles won't have it (if no suggestions were served). For some accounts you'll see generic suggestions (if we don't know their cluster).
Verify Discover interstitials work like before.