Animate the like button #5033
Merged
Animate the like button #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5033.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr8irvrv2p9s738ib4f0. |
|
haileyok
approved these changes
Aug 30, 2024
Comment on lines
122
to
142
| if (PlatformInfo.getIsReducedMotionEnabled()) { | ||
| likeAnimValue.value = 1 | ||
| } else { | ||
| likeAnimValue.value = withTiming(1, { | ||
| duration: 400, | ||
| easing: Easing.out(Easing.cubic), | ||
| }) | ||
| } |
There was a problem hiding this comment.
With these, you can tell the withTiming call to reduce motion if needed.
Suggested change
| if (PlatformInfo.getIsReducedMotionEnabled()) { | |
| likeAnimValue.value = 1 | |
| } else { | |
| likeAnimValue.value = withTiming(1, { | |
| duration: 400, | |
| easing: Easing.out(Easing.cubic), | |
| }) | |
| } | |
| likeAnimValue.value = withTiming(1, { | |
| duration: 400, | |
| easing: Easing.out(Easing.cubic), | |
| reduceMotion: ReduceMotion.System, | |
| }) |
Comment on lines
+10
to
+12
| Easing, | ||
| interpolate, | ||
| SharedValue, |
There was a problem hiding this comment.
Suggested change
| Easing, | |
| interpolate, | |
| SharedValue, | |
| Easing, | |
| interpolate, | |
| ReduceMotion, | |
| SharedValue, |
haileyok
reviewed
Aug 30, 2024
| @@ -45,6 +54,7 @@ import { | |||
| Heart2_Stroke2_Corner0_Rounded as HeartIconOutline, | |||
| } from '#/components/icons/Heart2' | |||
| import * as Prompt from '#/components/Prompt' | |||
| import {PlatformInfo} from '../../../../../modules/expo-bluesky-swiss-army' | |||
There was a problem hiding this comment.
Suggested change
| import {PlatformInfo} from '../../../../../modules/expo-bluesky-swiss-army' |
|
Just tried this out on the preview branch, it looks so good! Great job 👌🙏 |
mozzius
approved these changes
Aug 30, 2024
Closed
haileyok
added a commit
that referenced
this pull request
Aug 31, 2024
* Animate the like button * Respect reduced motion * Move like count into animated component * Animate text * Fix layout on Android * Animate text backwards too * Fix bad copypasta * Reflect nonlocal updates to animated values (cherry picked from commit ed232e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #4405 but a slightly different animation (inspired by the one in examples on the React homepage).
web.mov
ios.mov
android.mov