add emoji picker to chat composer #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleartux
commented
Sep 2, 2024
| } | ||
|
|
||
| interface IProps { | ||
| state: EmojiPickerState | ||
| close: () => void | ||
| showAbove?: boolean |
There was a problem hiding this comment.
I'm not sure this is the best naming and approach
nucleartux
commented
Sep 2, 2024
|
|
||
| import {atoms as a} from '#/alf' | ||
| import {textInputWebEmitter} from '../TextInput.web' |
There was a problem hiding this comment.
I have to move this out of TextInput because it is now used everywhere that EmojiPicker is used.
nucleartux
commented
Sep 2, 2024
Comment on lines
+148
to
+162
| <Button | ||
| onPress={e => { | ||
| e.currentTarget.measure((_fx, _fy, _width, _height, px, py) => { | ||
| openPicker?.({top: py, left: px, right: px, bottom: py}) | ||
| }) | ||
| }} | ||
| style={[a.p_xs, {marginTop: 3}]} | ||
| label={_(msg`Open emoji picker`)} | ||
| accessibilityHint={_(msg`Open emoji picker`)} | ||
| variant="ghost" | ||
| shape="round" | ||
| size="small" | ||
| color="primary"> | ||
| <EmojiSmile size="lg" /> | ||
| </Button> |
There was a problem hiding this comment.
Copy pasted from the post composer and changed size a bit
estrattonbailey
approved these changes
Sep 6, 2024
estrattonbailey
merged commit 4984f4e
into
bluesky-social:eric/web-chat-emoji
6 checks passed
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5059
How it looks:
How it works:
emoji.mov
I'm not sure about the design, though—particularly the button style and position.