[Statsig] Add more events to downsample, increase downsample rate #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5198.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-crdo5vjqf0us73bhs1pg. |
|
estrattonbailey
added a commit
that referenced
this pull request
Sep 7, 2024
* origin/main: Set show_follow_suggestions_in_profile to true (#5205) Set fixed_bottom_bar to true (#5203) [Statsig] Add more events to downsample, increase downsample rate (#5198) fix: remove duplicate style `rounded_sm` (#5201) Add cursor pointer to 'New post' button (#5109) Add emoji picker to chat composer (#5196) [Video] Handle push/pop on Android for autoplay (#5194) nvm fix action Trigger a build maybe Fix starter packs scroll (#5190) Redesign play button (#5192) cleanup quick integration of ipcc service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to do more downsampling of some events, because they are really noisy. Here we go! Doing two things here:
downsampleRateto downsampled event metadataTest Plan
This is a pretty simple change that is mostly verified by typecheck. Adding
sampledto the end of the existing events handles downsampling for us with existing logic.Testing that the metadata is being added can be done by just changing
isDownsampledSessiontofalse, then checking the network logs for something like post like (you'll need to spam some likes, doing it on a single post works).