Add web transition styles in interactive components #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichemfantar
changed the title
|
Hey! Really appreciate your work here. We have some plans to integrate button animation styles across the app, so I can't guarantee we'll be able to merge this, but I'm going to leave it open for now as a reference. Thanks again! |
|
@estrattonbailey sounds good to me! |
|
perhaps also consider enabling smooth scrolling when hitting the scroll to top button in the feed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the transition styles in the button components. It adds transition properties for all button variants and adjusts the transition duration. This improves the visual transition effects when interacting with buttons.
transition settings are from the recommended tailwind styles
suggestion: perhaps it would be a good idea to add this transition config as a reusable atom?
demo:
Screen.Recording.2024-09-18.at.11.56.14.AM.mp4
Screen.Recording.2024-09-18.at.11.55.49.AM.mp4
Screen.Recording.2024-09-18.at.11.55.26.AM.mp4
Screen.Recording.2024-09-18.at.11.54.53.AM.mp4
Screen.Recording.2024-09-18.at.11.54.09.AM.mp4