Revert change in FAB animation #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/revert-some-fab-tweaks - social-app PR #5465
Render
Destroyed
mozzius
approved these changes
Sep 24, 2024
|
estrattonbailey
added a commit
that referenced
this pull request
Sep 24, 2024
* origin/main: Remove image resizer (#5464) Remove `react-native-fs` (#5463) Revamp image editor (#5462) Revamp edit image alt text dialog (#5461) MobX removal take 2 (#5381) Edit self hosting copy (#5469) Automatically optimise SVG assets (#5467) [Share Extension] Update to support video (#5385) Revert change in FAB animation (#5465) Improvements to NSE (#4992) Don't use flex on inputs (#5458) Fix web splash (#5456) invert the fab animation, play a haptic (#4309) add sideborders to <ProfileHeaderLoading> (#4995) [Video] Flush low quality segments once focused (#5430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The "growing outward" animation didn't feel as good as hoped for on device. Let's revert to what we had before.
Also, I'm tweaking the haptic to be a
Lightvariant rather than the defaultMedium, since it does feel good but maybe a bit too strong.Test Plan
Animation should now be returned to what it was before, and he haptic should be a bit weaker.