Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up left nav on web #5488

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Clean up left nav on web #5488

merged 13 commits into from
Sep 26, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Sep 25, 2024 •
edited
Loading

Does a few things:

  • new compose button
  • fixes sizing/alignment of nav icons, these were a little wonky
  • increases font weight of active item
  • fixes sizing/alignment of notification dot, was a little wonky with the new type

New

CleanShot 2024-09-25 at 16 59 35@2x
CleanShot 2024-09-25 at 16 59 43@2x
CleanShot 2024-09-25 at 16 46 46@2x
CleanShot 2024-09-25 at 16 47 47@2x

Old

CleanShot 2024-09-25 at 16 49 14@2x
CleanShot 2024-09-25 at 16 50 55@2x
CleanShot 2024-09-25 at 16 49 18@2x
CleanShot 2024-09-25 at 16 49 47@2x

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Old size New size Diff
10.01 MB 10.01 MB 27 B (0.00%)

@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 25, 2024 21:48 — with Render Destroyed
@estrattonbailey estrattonbailey changed the title Tweak nav item count style Clean up left nav on web Sep 25, 2024
@estrattonbailey estrattonbailey marked this pull request as ready for review September 25, 2024 21:53
@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 25, 2024 21:59 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 25, 2024 22:17 — with Render Destroyed
@mary-ext
Copy link
Contributor

Closes #5083

@estrattonbailey estrattonbailey mentioned this pull request Sep 26, 2024
Merged
@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 26, 2024 14:52 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 26, 2024 15:03 — with Render Destroyed
@estrattonbailey
Merge remote-tracking branch 'origin/main' into left-nav-desktop
1e3cea4 
* origin/main:
  Adjust line height to not cut off emoji (#5496)
  Emoji in account list (#5497)
  Make the counter more rounded (#5083)
  add emoji prop to composer reply to text (#5495)
  Fix banner height in edit profile modal (#5494)
  Messages list - make avatars link to profile (#5484)
  Add back empty placeholder (#5489)
  Filter errors that get sent to Sentry (#5247)
  Add language filtering UI to search (#5459)
@estrattonbailey
Always a circle
701b0a0
@arcalinea arcalinea temporarily deployed to left-nav-desktop - social-app PR #5488 September 26, 2024 15:08 — with Render Destroyed
@estrattonbailey estrattonbailey merged commit 23dd638 into main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estrattonbailey @mary-ext @gaearon @arcalinea