Fix handle collapse on Android #5504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
android-handles - social-app PR #5504
Render
Destroyed
haileyok
approved these changes
Sep 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that somewhat rarely, handles were collapsing and not being shown at all on Android. We had some code in the previous version of
PostMetathat I had deleted, but evidently it was to handle this case.I was not able to reproduce a collapsed handle on iOS or web. The fix was to allow the display name and handle to expand, which pushes the timestamp all the way to the right, which matches what we have in production today.
Collapsed handle:
The fix was to allow the display name and handle to expand, which pushes the timestamp all the way to the right:
Which matches what we have in production today:
