Remove top padding from shell, move down into individual screens #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
surfdude29
reviewed
Oct 1, 2024
arcalinea
temporarily deployed
to
samuel/top-padding - social-app PR #5548
Render
Destroyed
mozzius
force-pushed
the
samuel/top-padding
branch
2 times, most recently
from
0ebfe6f to
240c70a
Compare
estrattonbailey
approved these changes
Oct 14, 2024
This reverts commit 240c70a.
mozzius
force-pushed
the
samuel/top-padding
branch
from
13b3ca9 to
21e1466
Compare
gpp-0
pushed a commit
to gpp-0/bsky-app-fork
that referenced
this pull request
Oct 14, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new
<Layout.Screen>which is responsible for a) setting the top inset and b) setting the correct height. Painful but it should clean up a lot of jank in lesser-touched screensThis lets us disable it selectively e.g. for the profile screen (PR to follow!)
The intent is to migrate more features, such as CenteredView and the various headers into these
<Layout.xyz>componentsHowever, since we have to remove it from the shell, we can't incrementally migrate it, so we also have to use it in every screen in the app in one giant PR. Sorry :(
Test plan
Go to every single screen on the app 😅 and make sure it looks the same. Also needs to be done on web too. I'm so sorry