Include ghost hook to statically export fonts #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
fonts-build - social-app PR #5553
Render
Destroyed
|
haileyok
approved these changes
Oct 1, 2024
|
Gonna merge this for now to test, will update further if we hear back from Expo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
expo exportwhen building for OTA updates. The although theexpo-fontplugin works for production builds, theexportCLI command does not use the plugin config, and therefore does not output our font files for use in the OTA bundle.The
useFontshook here ensures that the fonts are exported for native OTA, even though it is not otherwise used.