[Sheets] [Pt. 1] Root PR #5557

haileyok · 2024-10-01T20:59:56Z

This is a base PR for each stacked Sheets PR. Instead of merging each into main, start from #5560 and merge them down into this PR. Once everything is reviewed and ready to go, this PR can get merged into main.

This PR does not add any new behavior, just removes a bit of code so not much testing is needed on this one. Check each PR for a test plan.

github-actions · 2024-10-01T21:06:36Z

Old size	New size	Diff
7.92 MB	7.92 MB	0 B (0.00%)

Co-authored-by: Samuel Newman <mozzius@protonmail.com>

…5564)

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: dan <dan.abramov@gmail.com>

Co-authored-by: Samuel Newman <mozzius@protonmail.com>

estrattonbailey

goated fr ✨

quiple · 2024-10-05T07:59:53Z

src/components/moderation/LabelsOnMeDialog.tsx

+          <Trans>Appeal "{strings.name}" label</Trans>
+        </Text>
+        <Text style={[a.text_md, a.leading_snug]}>
+          <Trans>This appeal will be sent to</Trans>{' '}


It is inappropriate to leave the labeler name outside the <Trans> tag. This prevents proper localization in languages with different word order.

Yea this was accidentally left behind, should have been reverted. Merged in changes to fix this, thanks for noticing and commenting about it!

quiple · 2024-10-05T08:02:33Z

src/components/moderation/ModerationDetailsDialog.tsx

+          ) : (
+            <>
+              <Text style={[t.atoms.text, a.text_md, a.leading_snug, a.mt_lg]}>
+                <Trans>This label was applied by </Trans>


Same issue here.

quiple · 2024-10-05T08:09:04Z

src/components/moderation/ModerationDetailsDialog.tsx

-              <Trans>
-                This label was applied by{' '}
-                <InlineLinkText
-                  label={desc.source || _(msg`an unknown labeler`)}


And could you please provide the full sentence when an unknown labeler is displayed so that it can be localized?

As when applied by the author above.

Could you verify (either by replying here or in the linked PR) that this fixes the problem here? https://github.com/bluesky-social/social-app/pull/5616/files#diff-70b5ca5a14b0410abcadacda7727faa8219f009b561533160ee75331fdd545da

(@tkusano thank you!)

remove

64c9d86

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 1, 2024 21:00 — with Render View deployment

mozzius approved these changes Oct 2, 2024

View reviewed changes

[Sheets] [Pt. 2] Remove a bunch of now-unnecessary things (#5560)

a2e8f3c

Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 2, 2024 21:43 — with Render Destroyed

[Sheets] [Pt. 3] Get new sheet working with ScrollableInner (#5561)

5b08aad

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 2, 2024 21:58 — with Render View deployment

[Sheets] [Pt. 4] Convert Pressable in Menu (WIP) (#5562)

0037353

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 2, 2024 22:49 — with Render Destroyed

[Sheets] [Pt. 5] Update types and props (#5563)

ede5d01

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 2, 2024 23:03 — with Render Destroyed

haileyok changed the title ~~[Sheets] [Pt. 1] Remove importantForAccessibility~~ [Sheets] [Pt. 1] Root PR Oct 2, 2024

[Sheets] [Pt. 6] Update Inner and InnerFlatList and their uses (#…

0ed5d48

…5564)

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 2, 2024 23:14 — with Render View deployment

[Sheets] [Pt. 7] Part seven rework, much simplier! (#5582)

ecf7215

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:11 — with Render Destroyed

[Sheets] [Pt. 8] Allow nesting in other sheets or native modals (#5567)

c491820

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:27 — with Render Destroyed

[Sheets] [Pt. 10] (#5581)

4466f68

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:38 — with Render Destroyed

[Sheets] [Pt. 11] Move native code into repo (#5583)

79996ac

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:43 — with Render Destroyed

[Sheets] [Pt. 12] Add event for selected snap point change (#5584)

14e3567

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:49 — with Render Destroyed

[Sheets] [Pt. 13] Keyboard handling (#5586)

52a8e4d

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 04:53 — with Render Destroyed

[Sheets] [Pt. 14] Portaling behaviors for nested dialogs (#5588)

058ddb0

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 3, 2024 05:03 — with Render Destroyed

[Sheets] [Pt. 15] Fix up dialogs inside the composer (#5589)

89ac125

Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: dan <dan.abramov@gmail.com>

fix event not firing (#5603)

658a352

Co-authored-by: Samuel Newman <mozzius@protonmail.com>

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 16:19 — with Render Destroyed

estrattonbailey added 5 commits October 4, 2024 11:25

Handle needs to be absolute

6a3b1aa

Remove space above Flatlist and apply to usages

4c6cb95

Add a little padding to bottom of menu

8e119f3

Fix padding on ScrollableInner

dfa1e5c

Fix todo

597ecb3

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 16:36 — with Render View deployment

haileyok added 3 commits October 4, 2024 10:11

rm log

e8f1a73

more inset tweaks

6b81ebe

disable drag android when needed

6ae75c8

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 17:38 — with Render View deployment

be sure to fire detent event

2d13212

arcalinea deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 17:55 — with Render View deployment

estrattonbailey approved these changes Oct 4, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into hailey/dialogs-pt1

992a5e8

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 20:14 — with Render Destroyed

types

84cc00f

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 20:19 — with Render Destroyed

oops

144f587

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 20:20 — with Render Destroyed

Merge remote-tracking branch 'origin/main' into hailey/dialogs-pt1

3f51721

arcalinea temporarily deployed to hailey/dialogs-pt1 - social-app PR #5557 October 4, 2024 20:20 — with Render Destroyed

haileyok merged commit 00486e9 into main Oct 4, 2024
6 checks passed

haileyok deleted the hailey/dialogs-pt1 branch October 4, 2024 20:24

quiple reviewed Oct 5, 2024

View reviewed changes

tkusano mentioned this pull request Oct 5, 2024

Enclose the entire message in Trans tags for translation #5616

Merged

haileyok mentioned this pull request Oct 6, 2024

ALT compose window for GIFs on iOS #4225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Sheets] [Pt. 1] Root PR #5557

[Sheets] [Pt. 1] Root PR #5557

haileyok commented Oct 1, 2024 •

edited by mozzius

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

estrattonbailey left a comment

quiple Oct 5, 2024

haileyok Oct 5, 2024

quiple Oct 5, 2024

quiple Oct 5, 2024 •

edited

Loading

haileyok Oct 5, 2024

[Sheets] [Pt. 1] Root PR #5557

[Sheets] [Pt. 1] Root PR #5557

Conversation

haileyok commented Oct 1, 2024 • edited by mozzius Loading

github-actions bot commented Oct 1, 2024 • edited Loading

estrattonbailey left a comment

Choose a reason for hiding this comment

quiple Oct 5, 2024

Choose a reason for hiding this comment

haileyok Oct 5, 2024

Choose a reason for hiding this comment

quiple Oct 5, 2024

Choose a reason for hiding this comment

quiple Oct 5, 2024 • edited Loading

Choose a reason for hiding this comment

haileyok Oct 5, 2024

Choose a reason for hiding this comment

haileyok commented Oct 1, 2024 •

edited by mozzius

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading

quiple Oct 5, 2024 •

edited

Loading