Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font tweaks #5597

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Font tweaks #5597

merged 3 commits into from
Oct 4, 2024

Conversation

estrattonbailey
Copy link
Member

Noticed that InterVariable renders a little light on Android. So this PR:

  • renames font weight tokens to be agnostic of their actual file names
  • bumps up those font weight tokens for Android vs iOS & web by one weight step
  • uses those tokens for the source of truth for the old Text component via the old theme
  • fixes a stray fontWeight in ProfileHeaderDisplayName, sets to heavy since it's large text
  • fixes a stray fontWeight in the drawer
  • removes the old Html file which has never been used afaik

@arcalinea arcalinea temporarily deployed to font-tweaks - social-app PR #5597 October 3, 2024 20:38 — with Render Destroyed
Copy link

github-actions bot commented Oct 3, 2024

Old size New size Diff
7.91 MB 7.91 MB 0 B (0.00%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid

@estrattonbailey estrattonbailey merged commit ce53b3a into main Oct 4, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Oct 4, 2024
* origin/main:
  Make composer reducer source of truth for images/video when publishing (#5595)
  Track links and embeds in the composer reducer (#5593)
  Bump SDK (#5602)
  Update built asset caching (#5601)
  Downgrade sentry to recommended 5.24.3 (#5604)
  Add option to search in any language (#5598)
  Font tweaks (#5597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants