Include hydrated responses for other records #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
embed-others-2
branch
from
a47d7b5 to
aa926f6
Compare
|
gaearon
force-pushed
the
embed-others-2
branch
from
246a7cd to
5c4ff8b
Compare
estrattonbailey
approved these changes
Oct 24, 2024
This is actually all it is now.
gaearon
force-pushed
the
embed-others-2
branch
from
5c4ff8b to
ed8125f
Compare
arcalinea
temporarily deployed
to
embed-others-2 - social-app PR #5646
Render
Destroyed
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Include hydrated responses for other records * Rename meta -> view This is actually all it is now.
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Include hydrated responses for other records * Rename meta -> view This is actually all it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #5645
This resolves the TODO related to hydrating other record types. When we fetch metadata for non-post records, we already get more info in the responses, but we currently only use their names. Let's include all fetched information in the type.
In a follow-up, we'll use this information to display real embeds for those records.
Test Plan
Verify can still embed non-post records. They'll still be displayed as external links for now.