Make default banner more palatable #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
default-banner - social-app PR #5676
Render
Destroyed
pfrazee
approved these changes
Oct 10, 2024
|
|
Good call good call |
|
Additional work on the Edit Profile dialog can happen in Sam's other PR imo |
|
On a first load of a new account, you could display an image in the header with instructions on changing the header as a lot of peeps obviously don't know how or choose not to. Something like this. The image included doesn't line up perfectly as I still don't know the precise resolution of the profile header. |
|
@layeredstrange that's a good idea, we'll discuss internally 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our avatar generation (even without) this blue default banner color is pretty garish. This tones it back to look a little nicer out of the gate.
Before
