Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance of feed reordering and add layout animations #5714

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Oct 11, 2024

Changes the "Edit Feeds" screen to bundle all of the changes into one save action. Also adds animations. Tested on web, ios sim, and android sim.

Mobile Desktop
https://github.com/user-attachments/assets/9c8f6fe6-da36-47f0-871c-70f4d42a8be7 https://github.com/user-attachments/assets/19258a16-e5e6-438a-abfc-c8984a3b5370

@arcalinea arcalinea temporarily deployed to fix-feed-reorder-perf - social-app PR #5714 October 11, 2024 05:39 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to fix-feed-reorder-perf - social-app PR #5714 October 11, 2024 05:41 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to fix-feed-reorder-perf - social-app PR #5714 October 11, 2024 05:44 — with Render Destroyed
Copy link

Old size New size Diff
7.89 MB 7.89 MB 1.28 KB (0.02%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works on both ios and web. also checked reduced motion. could maybe play w/ animation duration (150?)

@estrattonbailey
Copy link
Member

Niiiiice. Long overdue.

New brain worm to fix one day: the non-centered ViewHeader title when there's a button in there lol.

Also one small thing, I feel like the save button may get missed. Unsure on options. Maybe instead of the button in the header we add a section below the header so we can add text like "When you're done press save" or something.

@pfrazee
Copy link
Collaborator Author

pfrazee commented Oct 11, 2024

@estrattonbailey agree, we should add a todo to replace that header

@pfrazee pfrazee merged commit 157011e into main Oct 11, 2024
6 checks passed
@pfrazee pfrazee deleted the fix-feed-reorder-perf branch October 11, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants