Fix weird ALT label press behavior in embedded images #5751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this actually doesn't make a visible difference at this point which is why i didn't change it before, but the behavior is still technically weird without it. pressing on the badge does register a press on the embedded image like expected, but it's not at the point of contact. this is visible when an android ripple is added to the pressable enclosing the image
gpp-0
force-pushed
the
fix-weird-alt-label-touch-event
branch
from
ed5f9f6 to
681a77b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On posts with more than one embedded image, pressing on the ALT label on any of the images registers a press on the rest of the post instead of on the image, which is weird, see video. This doesn't happen with a single embedded image
a.mp4
EDIT: This is what happens in posts with a single embedded image (added ripple for visibility). It looks like it does register a press on the actual image but it's kinda funky (it starts at the top right corner instead of at the point of contact), so that should probably be fixed too
b.mp4
I disabled pointer events on the badges and now it works fine i think