Add more Android ripples #5757
Open
Add more Android ripples #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind bringing this up-to-date? Sounds like a good idea |
posts that appear on the home tab already have ripples. this also adds ripples on posts that appear in the search and notification tabs, in replies, and in embedded quotes. ripples on posts that appear in replies look kinda ugly (especially in threaded mode) because the pressable area doesn't extend horizontally to the edges of the screen, not sure if something should be done about this
gpp-0
force-pushed
the
add-android-ripple
branch
from
7795ba7 to
e0f313e
Compare
Moved some paddings around to remove the gap that appears to the left and right of treeview replies that was not covered by the ripple previously. Now the pressable itself extends from the rightmost thread border line thingy all the way to the right edge of the screen. I tried to make sure that the layout stays exactly the same as before, which unfortunately required some annoying style logic...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this was a deliberate design choice but the lack of ripple effects on Android makes the app feel very unresponsive to me, so I tried adding them in some places where I feel they make sense.
What I added
view/com/util/Linkcomponent but that looks like a hack and is probably not goodTouchableOpacitythat only covered part of the image so now the entire image is pressableWhat is missing
components/Linkelement because I couldn't figure out how to do it properly. Those include Cards (as inProfileCard,FeedCardetc.), user avatars on posts, and embedded external links