Move self-label button #5780
Merged
Move self-label button #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haileyok
commented
Oct 16, 2024
•
haileyok
commented
|
Base automatically changed from
hailey/self-label-dialog-design
to
hailey/add-gore-selflabel
October 16, 2024 22:56
haileyok
commented
Oct 16, 2024
| )} | ||
| <Animated.View | ||
| style={[a.flex_row, a.p_sm, t.atoms.bg, bottomBarAnimatedStyle]}> | ||
| <ScrollView |
There was a problem hiding this comment.
A ScrollView because we want to handle accessibility font sizes gracefully.
|
This looks great, thanks @haileyok! :) |
|
|
|
Yea seems legit, I had some hesitation around that wording as well. Sorta think we could rephrase the interactions button too. |
mozzius
force-pushed
the
hailey/tweak-button
branch
from
0a4a11e to
3848184
Compare
|
Proposal
|
mozzius
approved these changes
Oct 17, 2024
arcalinea
temporarily deployed
to
hailey/tweak-button - social-app PR #5780
Render
Destroyed
* Tweak it moar * Pluralize
arcalinea
temporarily deployed
to
hailey/tweak-button - social-app PR #5780
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/tweak-button - social-app PR #5780
Render
Destroyed
This was referenced Oct 17, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* move self label button? * rm * make sure its usable on large font sizes * tweak wording * update icon * tweaks * change button label and change opacity when no media (bluesky-social#5794) * Tweak it moar (bluesky-social#5807) * Tweak it moar * Pluralize * Labels --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: Eric Bailey <git@esb.lol>
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* move self label button? * rm * make sure its usable on large font sizes * tweak wording * update icon * tweaks * change button label and change opacity when no media (bluesky-social#5794) * Tweak it moar (bluesky-social#5807) * Tweak it moar * Pluralize * Labels --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: Eric Bailey <git@esb.lol>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.