Ensure all configured appLabelers are applied for logged out users #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
mod-pwi - social-app PR #5784
Render
Destroyed
|
arcalinea
temporarily deployed
to
mod-pwi - social-app PR #5784
Render
Destroyed
haileyok
approved these changes
Oct 17, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
…luesky-social#5784) * Ensure all configured appLabelers are applied for logged out users * Formatting
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
…luesky-social#5784) * Ensure all configured appLabelers are applied for logged out users * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BskyAgent.appLablersis a static property that's configured viaconfigureAdditionalModerationAuthoritiescalled in our session code. This was working for logged in users becauseBskyAgentinternally runs this same bit of code when we callgetPreferences. But for logged out users, we were only configuring the Bluesky labeler by default.This PR uses the same source of truth for logged out users as for logged in users:
BskyAgent.appLabelers. It applies the sameDEFAULT_LOGGED_OUT_LABEL_PREFERENCESconfig as well.