Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PageWithHeader header leaking into safe area #5792

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 17, 2024

Just needed a cheeky overflow: hidden :)

Before After
Screenshot 2024-10-17 at 11 22 32 Screenshot 2024-10-17 at 11 22 05

@arcalinea arcalinea temporarily deployed to samuel/fix-pagewithheader-layout - social-app PR #5792 October 17, 2024 08:23 — with Render Destroyed
Copy link

Old size New size Diff
7.9 MB 7.9 MB 0 B (0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good call for now 👍

@estrattonbailey estrattonbailey merged commit 59f9cd9 into main Oct 17, 2024
6 checks passed
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
* fix header leaking out of safe area

* make fix native-only
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
* fix header leaking out of safe area

* make fix native-only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants