Put ExternalEmbedRemoveBtn on top #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
video-remove - social-app PR #5887
Render
Destroyed
Merged
|
gaearon
reviewed
Oct 21, 2024
| @@ -11,7 +11,7 @@ export function ExternalEmbedRemoveBtn({onRemove}: {onRemove: () => void}) { | |||
| const {_} = useLingui() | |||
|
|
|||
| return ( | |||
| <View style={[a.absolute, a.pt_sm, a.pr_sm, {top: 0, right: 0}]}> | |||
| <View style={[a.absolute, a.pt_sm, a.pr_sm, a.z_50, {top: 0, right: 0}]}> | |||
There was a problem hiding this comment.
this seems like it would be better fixed at the usage site, no? we can't guess the necessary z-order here, but we can be more certain in the place that defines the actual ordering (and it's possible we can also fix this by changing the DOM order itself)
gaearon
approved these changes
Oct 21, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidently wasn't high enough in certain contexts (video). This seem to work not for all embed types.