Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Gist embed support #5926

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add GitHub Gist embed support #5926

wants to merge 6 commits into from
+341 −14

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Oct 24, 2024 •
edited
Loading

Adds embed support for gists. Notable missing features:

  • no syntax highlighting
  • multi-file (this just pulls the first file)
  • doesn't render markdown or HTML or anything like

Notes:

  • If we can find a lightweight x-platform solution for syntax highlighting, it's a maybe, but we don't want a long-tail of maintenance for every language. It may be better to offload to a server to statically render that, tbd.

CleanShot 2024-10-31 at 12 07 44@2x
CleanShot 2024-10-31 at 12 08 09@2x
CleanShot 2024-10-31 at 12 08 32@2x

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Old size New size Diff
8.03 MB 8.04 MB 4.73 KB (0.06%)

@estrattonbailey estrattonbailey marked this pull request as ready for review October 31, 2024 17:07
@arcalinea arcalinea temporarily deployed to gists - social-app PR #5926 October 31, 2024 17:22 — with Render Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estrattonbailey @arcalinea