Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicates in thread composer #6068

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix duplicates in thread composer #6068

merged 1 commit into from
Nov 1, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 1, 2024

Due to multiple subscriptions to the same global emitter, things were getting duplicated on the web.

Now there is only one active subscription, corresponding to the active input.

Test Plan

  • Draft a thread and press Cmd+Enter.
    • Before: Thread gets posted N times.
    • After: Thread gets posted once.
  • Drag an image from desktop.
    • Before: Image gets inserted into each post N times.
    • After: Image gets inserted into the current post once.
  • Paste an image from clipboard.
    • Before: Image gets pasted into each post.
    • After: Image gets pasted into the current post.
  • Choose an emoji in the web picker.
    • Before: Emoji gets added to every post.
    • After: Emoji gets added to the current post.

@arcalinea arcalinea temporarily deployed to composer-fix-dupes - social-app PR #6068 November 1, 2024 20:49 — with Render Destroyed
@gaearon gaearon mentioned this pull request Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Old size New size Diff
8.14 MB 8.14 MB 73 B (0.00%)

Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works, lgtm!

@gaearon gaearon merged commit 46004fb into main Nov 1, 2024
6 checks passed
@gaearon gaearon deleted the composer-fix-dupes branch November 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants