Set Inter to use ss02 disambiguation styleset #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benharri
force-pushed
the
stylistic-two
branch
4 times, most recently
from
542923f to
ad69ccb
Compare
|
Another less disruptive option is to use Gitlab used that for their version of Inter: character variants aren't in the react native fontVariant though... |
|
If this is not a desired change, I'm happy to close this out. |
benharri
force-pushed
the
stylistic-two
branch
2 times, most recently
from
c344a3d to
6c1eda6
Compare
|
this needs a look from @estrattonbailey |
benharri
force-pushed
the
stylistic-two
branch
2 times, most recently
from
eafa6b3 to
f8c4674
Compare
this isn't working on web and i don't know why add ss02 to templates/fallback styles
benharri
force-pushed
the
stylistic-two
branch
from
f8c4674 to
14156c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ss02 to Inter which is the disambiguation set https://rsms.me/inter/#features
It makes ILli1 a lot easier to tell apart.
Haven't been able to get this working on web. Seems that some react-native-web styles are overriding it and the font-feature-settings aren't getting applied correctly.
Looks great on android though
Thread with some more info
https://bsky.app/profile/benharri.org/post/3l7r4sv42sk2q