[Lightbox] Set 2 as minimal allowed zoom level #6132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
min-zoom-2 - social-app PR #6132
Render
Destroyed
|
gaearon
changed the title
arcalinea
temporarily deployed
to
min-zoom-2 - social-app PR #6132
Render
Destroyed
mozzius
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image resolution is low, both iOS and Android lightboxes didn't let you pinch it at all, and double tap would zoom it out. This fixes the issue by ensuring the max zoom scale we pass to the scroll view is always positive. I set it to allow at least 2x magnification (for small images — for highres images it would magnify more, as before).
Test Plan
Try this post: https://bsky.app/profile/neoxperson.bsky.social/post/3kaxlxr5tv622
Previously, the lightbox would zoom out on double tap. Now it slightly zooms in (and pinching also works).