Show full follower/following/post count metrics in tooltips #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBuchanan314
commented
Nov 7, 2024
|
|
||
| return ( | ||
| <View | ||
| style={[a.flex_row, a.gap_sm, a.align_center, a.pb_md]} | ||
| style={[a.flex_row, a.gap_sm, a.align_center, a.pb_md, {zIndex: 1}]} |
There was a problem hiding this comment.
zIndex:1 was required to make the tooltip appear on top of the bio text below, idk if this is the "correct" place to put it
There was a problem hiding this comment.
Suggested change
| style={[a.flex_row, a.gap_sm, a.align_center, a.pb_md, {zIndex: 1}]} | |
| style={[a.flex_row, a.gap_sm, a.align_center, a.pb_md, a.z_10]} |
DavidBuchanan314
commented
Nov 7, 2024
Comment on lines
-56
to
+70
| <Text style={[a.font_bold, t.atoms.text, a.text_md]}> | ||
| {formatCount(i18n, profile.postsCount || 0)}{' '} | ||
| <Text style={[t.atoms.text_contrast_medium, a.font_normal, a.text_md]}> | ||
| {plural(profile.postsCount || 0, {one: 'post', other: 'posts'})} | ||
| </Text> | ||
| <Text | ||
| style={[t.atoms.text_contrast_medium, a.text_md]} | ||
| title={postCountFull}> | ||
| <Text style={[t.atoms.text, a.font_bold, a.text_md]}>{postCount} </Text> | ||
| {pluralizedPostCount} |
There was a problem hiding this comment.
I had to invert the nesting order of these <Text> elements so that the outer one was non-bold, and the inner one was bold, so that the tooltip text would be non-bold when attached to the outer element. Hopefully I didn't break anything in the process.
|
I think the styling of the tooltips could be improved a little (hairline border? shadow?), but I'm not sure where else they're used and didn't want to break anything. (existing styling is in src/style.css) |
|
See also #5038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: no way to see non-truncated metrics!
After: full metrics are visible on hover, like so (cursor not visible in screenshot)
I've only tested this on desktop firefox, and I assume it doesn't do anything on mobile at all (maybe you can tap and hold? idk)