Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show precise count in label/hover text #6164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljharb
Copy link

@ljharb ljharb commented Nov 8, 2024

The intention is to expose the precise number of followers somewhere. Currently I have "1.1K", but until that drops to "1K" or rises to "1.2K", i'll have no idea where in that hundred-range the number falls.

I'm sure I'll need to do something with tests, and maybe still format the count in a less-approximate way - please give me some pointers since I'm very unfamiliar with the codebase.

I'd also like to expand this PR to show the full count on the /follows and /followers pages so it's easily visible on mobile, but i thought i'd start here :-)

@mozzius
Copy link
Member

mozzius commented Nov 8, 2024

We had a PR somewhere that showed the exact count on hover as a tooltip - I'll see if I can dig it up

@surfdude29
Copy link
Contributor

We had a PR somewhere that showed the exact count on hover as a tooltip - I'll see if I can dig it up

There are two that I'm aware of: #6146 and #5038

@ljharb
Copy link
Author

ljharb commented Nov 9, 2024

awesome, if one of those is ready, then let's land one! :-) i'm attached to the capability, not to any given implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants