Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Show badge' button label being cut off #6215

Conversation

khuddite
Copy link
Contributor

@khuddite khuddite commented Nov 10, 2024

Fixes #6185

  1. Summary
    Show badge label is cut off on the developer labels page.

  2. Solution
    Before:
    image
    After:
    CleanShot 2024-11-10 at 15 26 03

The fix looks better than being cut off, but I am unsure if it is the best solution to the problem. I can think of different ways of solving it, and here are some of them
- Updating the label to say Show instead of Show badge
- Increasing the button width for all 3
- Put the toggle group underneath title/description section like on mobile devices

I guess, I need some design inputs here on what is the desired behavior aesthetically.

@nspilman
Copy link

Thanks for this fix! Came here to try to do the same thing :-)

@JoshMLeslie
Copy link

+1 for "Show" instead of "Show Badge" as it's redundant. I'm more curious the distinction b/w "off" and "hide". The header description could be more verbose imo.

@estrattonbailey estrattonbailey changed the base branch from main to eric/show-badge-cut-off November 13, 2024 18:36
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Much appreciated 🙏

@estrattonbailey estrattonbailey merged commit 63d3e02 into bluesky-social:eric/show-badge-cut-off Nov 13, 2024
6 checks passed
gaearon pushed a commit that referenced this pull request Nov 13, 2024
* Fix 'Show badge' button label being cut off (#6215)

* Make em full width

---------

Co-authored-by: Khuddite <62555977+khuddite@users.noreply.github.com>
@victor-ponamariov
Copy link

+1 for just "Show".

But generally speaking, I'm very confused about the whole thing. We have labelers, that can add labels to our profiles via likes, right?

Labels are annotations on users and content. They can be used to hide, warn, and categorize the network.

So, what these three buttons actually do. Off, show, and hide. Is it about fine-tuning your feed, to hide people who have some labels? Then... why there are three buttons, not two (show/hide)?

And what happens if 2 labelers create a label with the same name (while in the database they'll have unique ids I believe), so we'll end up with two "Javascript" for example from two accounts/labelers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label "Show Badge" is cut off
5 participants