Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lightbox] Small tweaks #6301

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[Lightbox] Small tweaks #6301

merged 4 commits into from
Nov 13, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 13, 2024 •
edited
Loading

  • Tweak lightbox animations to have smaller durations
  • Smaller velocity threshold for the dismiss gesture
  • Disable iOS "scroll to top" while lightbox is active to prevent unintentional feed scrolls

@arcalinea arcalinea temporarily deployed to tweak-springs - social-app PR #6301 November 13, 2024 16:44 — with Render Destroyed
@github-actions GitHub Actions
Copy link

Old size New size Diff
8.02 MB 8.02 MB 0 B (0.00%)

@arcalinea arcalinea temporarily deployed to tweak-springs - social-app PR #6301 November 13, 2024 16:56 — with Render Destroyed
@gaearon gaearon merged commit 4ca5267 into main Nov 13, 2024
6 checks passed
@gaearon gaearon deleted the tweak-springs branch November 13, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

@pfrazee pfrazee Awaiting requested review from pfrazee

@estrattonbailey estrattonbailey Awaiting requested review from estrattonbailey

@mozzius mozzius Awaiting requested review from mozzius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @haileyok @arcalinea