Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase strength of check for post stats guard #6307

Closed
wants to merge 1 commit into from

Conversation

estrattonbailey
Copy link
Member

Some folks noticed during the outage earlier today that quoteCount wasn't returned on responses, which caused this section to display with no contents. This PR checks for the existence of these values, and the only shows the section if any of the values are > 0.

This should be a very rare case.

@arcalinea arcalinea temporarily deployed to guard-post-stats - social-app PR #6307 November 13, 2024 20:52 — with Render Destroyed
Copy link

Old size New size Diff
8.02 MB 8.02 MB 96 B (0.00%)

Copy link

@kankenny kankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estrattonbailey
Copy link
Member Author

Closing in favor of fixing this on the backend bluesky-social/atproto#2990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants