Fix translate button not working #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still not able to reproduce this. |
gaearon
reviewed
Nov 23, 2024
|
OK, I can repro it on web at least |
gaearon
force-pushed
the
fix-translate-button
branch
from
c8da126 to
8dd11d2
Compare
|
Slightly tweaked the fix. Couldn't repro the original issue outside web but I think this should work. |
gaearon
approved these changes
Nov 23, 2024
This was referenced Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6289
Fix #6287
Fix #6446
Sorry I know this is a bit repetitive, but I’m trying to provide more explanation in this PR. I've encountered this issue frequently over the past few days.
Thanks to @surfdude29’s comment, made me realize that there is a behavioral difference between clicking "Translate" in the post context menu and directly clicking the translate button under the post, so I started investigating this.
In #6084, to fix the a11y issue, we replaced
<NewText>with<InlineLinkText>, which introducedto="#". But this breaks the translation and redirects the user to the homepage.I absolutely respect the a11y fix, so I won’t revert this change. Replacing
onPress={onTranslatePress}withto={translatorUrl}seems like the right approach. After removingonPresshere, it will no longer be used elsewhere, so it can be safely removed import.After testing, the translation button will work again.
test.mp4