forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream 20230918 #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use create2 to deploy L1 contract implementations. This is useful to deduplicate config, making the contracts have canoncial addresses per version across networks. Every L1 contract implementation should use the same create2 salt over time.
Upgrade from node.js v16 to v18. v16 starts end of life on 9/11/2023, meaning it will no longer get security updates. v18 is currently LTS, https://github.com/nodejs/release#release-schedule for additional information. We previously were not able to upgrade node.js versions because we were using an older version of hardhat that did not support newer versions of node.js but that is no longer the case.
Co-authored-by: Will Cory <willcory10@gmail.com>
…/node-lts deps: use node lts
…create2-deploy contracts-bedrock: use create2 to deploy implementations
…xer.legacy.blocks feat(indexer): bridge process pre-bedrock blocks
Bumps [markdownlint](https://github.com/DavidAnson/markdownlint) from 0.30.0 to 0.31.0. - [Changelog](https://github.com/DavidAnson/markdownlint/blob/main/CHANGELOG.md) - [Commits](DavidAnson/markdownlint@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: markdownlint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ndabot/npm_and_yarn/markdownlint-0.31.0 build(deps-dev): bump markdownlint from 0.30.0 to 0.31.0
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.62.0 to 6.7.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Migrate away from using `Semver` where the semantic version is immutable to using `ISemver` where the semantic version is a constant. Only update the L1 contracts, this change should be followed up with additional PRs that update the other contracts. This change simplifies the code and reduces the bytecode size of each of the contracts.
…ell/redo-subscription feat: Head Subscriptions
…ix-last-step op-challenger: Fix recording of last step index
…4-fix_indexer_Fix_tygo_check_in_ci fix(indexer): Fix tygo check in ci
Updates the implementation salt. Without this change, the deployments fail on Goerli. They work on the devnet so something must be different between the devnet and the live network. This change will ensure that there is less config to manage in the superchain registry by having a canonical address for each semver version. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…oid intermediate state.
…ocol-versions-contract contracts-bedrock: ProtocolVersions contract
…ode-protocol-versions-handling op-node: protocol versions signal handling
…_fix Cancel any inflight block building when stopping the sequencer, to av…
jyellick
force-pushed
the
jyellick/merge-upstream-20230918
branch
2 times, most recently
from
September 18, 2023 16:37
9a987e0
to
c4440c9
Compare
jyellick
force-pushed
the
jyellick/merge-upstream-20230918
branch
from
September 18, 2023 16:38
c4440c9
to
1cf4d21
Compare
boyuan-chen
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The devnet-hardhat
test passes, so smart contract changes are compatible.
mmontour1306
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another Monday merge.
Note, that there are many contract changes:
As best as I can tell, these contract changes are all backwards compatible -- ie, nothing has been removed. So, I think this merge should be safe, but someone more well versed with solidity should certainly review.