Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to use your own canonical template #2559

Merged
merged 4 commits into from
May 2, 2021
Merged

Added option to use your own canonical template #2559

merged 4 commits into from
May 2, 2021

Conversation

Spomsoree
Copy link
Contributor

I added a option to set you own canonical template.
I also added the option to get a relative path passed to the template, which makes it much more flexible.

I think this could be useful to others too.
Let me know if anything could be improved, I look forward to any feedback.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Spomsoree,

These are my favorite kind of PR's. It adds new functionality, but it doesn't break any existing functionality. And for people who don't need this particular feature, it stays out of the way! Thank you! 👍

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make csfix on this branch? That'll fix the CS things the CI is complaining about. ;-)

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants