Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with migration that wouldn't run on MariaDB 10 by specifying a primary key #2570

Closed
wants to merge 568 commits into from
Closed

fix issue with migration that wouldn't run on MariaDB 10 by specifying a primary key #2570

wants to merge 568 commits into from

Conversation

simongroenewolt
Copy link
Contributor

see #2569

@simongroenewolt
Copy link
Contributor Author

Note : this fix hasn't been checked with an existing sqlite db.

@bobdenotter
Copy link
Member

Hi @simongroenewolt,

The tests are failing because of some bitrot in dependencies. If you could rebase on master, tests will likely pass! :-)

simongroenewolt and others added 28 commits May 11, 2021 17:27
@simongroenewolt
csfix
dc1ae60
@simongroenewolt
change settings so ROLE_ADMIN keeps the same permissions - this shoul…
6f9cbef 
…d fix the tests
@I-Valchev @simongroenewolt
Update tests to pass permissions features
ebeeab8
@I-Valchev @simongroenewolt
csfix
c313532
@I-Valchev @simongroenewolt
Update users.feature
a12d536
@simongroenewolt
Made switch user voter a bit to restrictive
47a11ff
@simongroenewolt
separate editing 'own profile' from editing another user
61ebc25
@simongroenewolt
various updates to permissions.yaml
0265f75
@simongroenewolt
clean up BackendMenuBuilder.php: remove TODO items that have been don…
c46ae14 
…e and clean up empty nested menus
@simongroenewolt
clean up: remove TODO items that have been done
df0a1e6
@simongroenewolt
csfix
723f31d
@simongroenewolt
csfix
93be880
@simongroenewolt
english translation keys added
bd1e3e7
@simongroenewolt
updated permissions setup for user edit form (UserType.php)
b869f14
@simongroenewolt
fixed permissions for api in bolt admin (decided not to try and actua…
ec687c3 
…lly limit access to /bolt/api or /api)
@simongroenewolt
managed to come up with a reasonable way to limit access to translate…
8a68008 
… and api packages that don't have their controllers in the Bolt sources.
@bobdenotter @simongroenewolt
Clean up tests
c2d0650
@bobdenotter @simongroenewolt
Update users.feature
52002a2
@bobdenotter @simongroenewolt
Update users.feature
c1b1e93
@bobdenotter @simongroenewolt
Update users.feature
2d5bc37
@simongroenewolt
Update config in permissions.yaml so they will be (more or less) back…
30059ce 
…wards compatible. Use only ROLE_ADMIN and ROLE_EDITOR in config to keep things simple.
@bobdenotter @simongroenewolt
Prepare relase 4.2.0-beta.6
15ad380
@bobdenotter @simongroenewolt
Prepare Release 4.1.12
9d0676f
@I-Valchev @simongroenewolt
Fix |svg filter for images outside of set
670fdb2
@bobdenotter @simongroenewolt
New Skeleton theming
8351490
@simongroenewolt
remove ROLE_ADMIN check, no replacement needed as there is already a …
103b6d5 
…check in the locales() method on 'view' permission. (reference: bolt#2342)
@bobdenotter @simongroenewolt
This use is no longer needed
df7e700
@simongroenewolt
Update ROLE_ADMIN check to specific media_edit permission.
902525b
bobdenotter and others added 25 commits May 11, 2021 17:28
@bobdenotter @simongroenewolt
Fix datepicker to only attempt to use existing locales, ensuring Time…
c4f5750 
… Picking still works
@bobdenotter @simongroenewolt
Fix edgecase where Excerpt could start with . .
f773008
@I-Valchev @simongroenewolt
The latest directive uses -publishedAt instead of -id
3f6a0e5
@bobdenotter @simongroenewolt
Fixing e2e test 🙈
49c0dae
@bobdenotter @simongroenewolt
Prepare release 4.1.18
8676e17
@bobdenotter @simongroenewolt
Update CHANGELOG.md
b0a5b48
@bobdenotter @simongroenewolt
Update CHANGELOG.md
e73b90b
@DorienD @simongroenewolt
2177: Add sr only text to select all checkbox
ea7861d
@DorienD @simongroenewolt
Fix linting
6a47b68
@I-Valchev @simongroenewolt
Don't throw `Argument 2 passed to Bolt\Doctrine\JsonHelper::wrapJsonF…
e76f4d9 
…unction()` for checkboxes
@I-Valchev @simongroenewolt
Support multiple targets for widget, keeping $target too
b470d6a
@I-Valchev @simongroenewolt
Fix unit tests
3156829
@I-Valchev @simongroenewolt
Update BoltHeaderWidget.php
1313fd0
@I-Valchev @simongroenewolt
SnippetWidget has multiple targets
1eedf33
@I-Valchev @simongroenewolt
Allow single targets in SnippedWidget
68bf0d9
@Spomsoree @simongroenewolt
Added the missing additional targets widgets to the backend (bolt#2558)
af686a3
@bobdenotter @simongroenewolt
Fix a CSS quirk in listing overview pages
a92ad14
@Spomsoree @simongroenewolt
Made the canonical link widget use a overridable template
83b6d50
@Spomsoree @simongroenewolt
Added the option to get a relative path passed to the canonical template
d32eeba
@Spomsoree @simongroenewolt
Ran csfix to resolve the code style errors on the canonical template
2925d48
@bobdenotter @simongroenewolt
Kill it with fire
cbd53d0
@bobdenotter @simongroenewolt
Require opt-in for FLoC header
d3f4763
@bobdenotter @simongroenewolt
CS fix
6257b2b
@bobdenotter @simongroenewolt
Update src/Configuration/Parser/GeneralParser.php
8c02e1d
@simongroenewolt
fix issue with migration that wouldn't run on MariaDB 10 by adding a …
55fd452 
…primary key - bolt#2569
@simongroenewolt
Copy link
Contributor Author

hmmm, that clearly was the wrong order of rebase/push -- I'll abondon this PR and create a fresh one!

@simongroenewolt simongroenewolt deleted the fix/migration-for-mysql branch May 11, 2021 15:36
@bobdenotter
Copy link
Member

Been there, done that! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@simongroenewolt @bobdenotter @I-Valchev @eduardomart @tambait @kryst3q @EmilePerron @nestordedios @DorienD @Spomsoree