-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable and enhance CI #52
Comments
@mclow I found an issue building with C++03:
|
clearly that code is not going to work on C++03. I'll see if it can be made to do so. |
Fixed in develop. |
Still failing:
I will clean this up on my side and submit it with the PR. Could you turn on CI for Travis and AppVeyor per the instructions in https://github.com/jeking3/boost-ci (specifically item #11, enable Travis CI and AppVeyor for the boostorg/algorithm project), or I can manage those for you, but I would need to be marked as admin on this repo to do that. I think the include for type_traits can just be removed... |
@mclow clang 3.4, 3.8, 4.0, and 5.0 are failing in CI (clang 6.0 succeeds): The only change I made in that branch is to remove the Could you take a quick look and see if I did something wrong, or if it's a real issue? Full results are otherwise pretty good. All windows builds passed. The ubsan issue with gcc-8 on Boost.Test popped up again, and the clang 3.4, 3.8, 4.0, 5.0 issue can be seen: |
Looks like a capability mismatch in libstdc++ and code in algorithm, but gcc passes - however I see that with gcc 4.8 I use CXXSTD 03,11 when building, so I just have to tewak the build jobs.
|
The only remaining issue is a UBSAN issue:
I am going to submit a PR for this work which will fail on the UBSAN, and needs addressing. |
I've tried to reproduce the UBSAN failure locally (with clang and gcc 7.3), and failed. Here's my test case:
|
It is happening with gcc-8 ubsan however. |
Can you reproduce it with my sample program? (I won't have a chance to build gcc 8 until next weekend). |
Running it through CI now, will post results. |
Still failed. Sounds silly, but I wonder if this is because a virtual destructor is not defined?
If you need help enabling CI on algorithm let me know. There are instructions at: I wonder if we should consider moving that into boostorg... |
Is this an issue for Boost.Exception? Perhaps I should ramp up a CI for that repo? |
Travis and Appveyor files were added 5 months ago, but CI was never enabled for this repository.
Add codecov.io, cppcheck, covscan, ubsan, and valgrind targets to improve quality.
The text was updated successfully, but these errors were encountered: