Radix sort #2
Closed
Radix sort #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test of an implicitly convertible type.
|
if only the history would have been rebased and cleand up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team Algorithm!
Radix sort has been on the list of GSoC algorithms for the past two years and I enjoy implementing algorithms so here is my (almost complete) attempt. The early commit history is missing, I'm sorry, because I did most of the work before forking the Boost repository.
Some parts of the code that I'm not 100% confident about:
identity<T>: Is this the best way to support actual unsigned integral types and types that can be implicitly converted?tr1_result_of: Is this the right way to get result_of in this circumstance?Obviously the tests are embarrassingly duplicated and I haven't decided how to resolve that yet.
The only thing that is definitely incomplete is the documentation -- the code I am pretty happy with but eager to hear suggestions and criticism from others.
Cheers.