Skip to content

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Aug 28, 2018

The tests do not require fully-featured testing framework.
The lightweight_test alternative should also save on build times.


Motivation is drawn from recent discussions on #boost channel at cpplang.slack.com, about preferring the lightweight_test wherever possible, also to cut number of inter-dependencies in Boost.

@mclow
Copy link
Collaborator

mclow commented Aug 28, 2018

@mloskot - the problem with discussions on the slack channel (as opposed to the mailing list) is that they are not archived, and can't be reviewed later.

@mloskot
Copy link
Member Author

mloskot commented Aug 28, 2018

@mclow Right. However, I think that even if I did not mention it, the rationale behind the change should be clear enough.

@pdimov
Copy link
Member

pdimov commented Aug 28, 2018

You forgot to return boost::report_errors(); :-)

@mclow
Copy link
Collaborator

mclow commented Aug 28, 2018

It's not the motivation that I'm missing, but rather the discussion of the pros and the cons.

The tests do not require fully-featured testing framework.
The lightweight alternative should also save on build times.
@mloskot
Copy link
Member Author

mloskot commented Aug 28, 2018

@pdimov Thank you. I've updated the pull request.

@mclow The discussion was not very extensive, just that for simple needs lightweight_test should be enough, less dependency may decrease overall maintenance hassle, and such.

Quoting @mjcaisse

Boost.Test is in a peculiar position of being a dependency for so many pre-c++11 supporting libraries. As such it has a different set of constraints.

mclow added a commit that referenced this pull request Jul 10, 2019
@mclow
Copy link
Collaborator

mclow commented Jul 10, 2019

Committed a modified version of this as 453cf59

@mclow mclow closed this Jul 10, 2019
@mloskot mloskot deleted the ml/replace-utf-with-lightweight-test branch July 10, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants