Fixing problems reported in Boost Inspection Report #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing all these! Could you make this pull request against the |
|
Oh, sorry for this mistake :-) I'll add more fixes today and make pull Could you comment doubts/problems I listed?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some of problems reported in Boost Inspection Report for 1.59 beta rc1. I could not fix all of them due to problems/issues/doubts I described below.
I fixed violations of Boost min/max guidelines, converted tabs into spaces, added missing license information and copyrights (based on who and when created the file). I'm not sure how to correctly add missing license and copyright info to .qbk files.
I fixed one non-ASCII character in
/example/opencv_convolution.cpp, but I did not change names with non-ASCII character/s as I don't think it would be right.A few of Boost marcos used in Boost.Compute are deprecated, some since 1.50, some since 1.51. Boost.Compute requires Boost in version 1.48 or later. New macros that replaced deprecated ones (see Boost macros) are - of course - not present in 1.48, so if Boost.Compute should work with 1.48 we need to keep these deprecated macros. Otherwise, required Boost version should be set to 1.51.
( I also check that in
compute/include/boost/compute/config.hppinternal macros like BOOST_COMPUTE_DETAIL_NO_VARIADIC_TEMPLATES are defined, but still sometimes in the code original macros from Boost are used, so that should be fixed too? )