Skip to content

Conversation

jszuppe
Copy link
Contributor

@jszuppe jszuppe commented Jul 18, 2015

I fixed some of problems reported in Boost Inspection Report for 1.59 beta rc1.

  • I fixed violations of Boost min/max guidelines, converted tabs into spaces, added missing license information and copyrights (based on who and when created the file).
  • I fixed one non-ASCII character in /example/opencv_convolution.cpp, but I DID NOT change author name with non-ASCII character/s as I don't think it would be right.
  • I added BOOST_NO_CXX11_VARIADIC_TEMPLATES macro which replaces deprecated BOOST_NO_VARIADIC_TEMPLATES.
  • I also moved all BOOST_NO_* to config.hpp.
  • I used BOOST_COMPUTE_NO_ prefix for all these macros, but it's not a problem to changed the prefix if different is preferred (for example BOOST_COMPUTE_DETAIL_NO_).
  • (!) The last commit removes deprecated Boost macros and update required version of Boost Library to 1.55 (in Boost 1.48 new macros that replaces deprecated ones are not defined, theoretically 1.51 is enough, but IMO 1.55 is currently the most popular one + there are no packages for 1.51). This commit can be removed if we want to keep supporting 1.48 version.

@jszuppe jszuppe force-pushed the pr_boost_inspection branch 2 times, most recently from 99a15f4 to 0a1d6b8 Compare July 18, 2015 15:02
@kylelutz
Copy link
Collaborator

Looks good! As for your last comment, I think we still want to keep support for Boost 1.48 (at least until Boost.Compute is in the official Boost release).

@jszuppe
Copy link
Contributor Author

jszuppe commented Jul 18, 2015

OK, so I will remove last commit and it will be ready to merge.

@jszuppe jszuppe force-pushed the pr_boost_inspection branch from 0a1d6b8 to 7a8d078 Compare July 18, 2015 17:46
@jszuppe
Copy link
Contributor Author

jszuppe commented Jul 18, 2015

Done, last commit is removed. Deprecated macros will still generate problems in Boost inspection program, but we keep support for 1.48 version. My commit will wait patiently ;)

kylelutz added a commit that referenced this pull request Jul 18, 2015
Fixing problems reported in Boost Inspection Report
@kylelutz kylelutz merged commit 15a778d into boostorg:develop Jul 18, 2015
@jszuppe jszuppe deleted the pr_boost_inspection branch May 1, 2016 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants