Add missing return to svm_ptr assignment operator #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we need to find a stable POCL version (commit), use it instead of master branch because it became too unstable and just upgrade it from time to time after testing that new version is stable. |
|
Yeah, I think that would be better and make the CI results more dependable. Would it make sense to stick to POCL releases or other tagged versions? |
|
I'm not sure about releases (0.12 is 600 commits behind master, 0.13 - 200 commits behind) I will have to test them. If 0.13 works I'll use it, otherwise I'll just figure out the latest commit that works. I'll do this on Saturday. |
|
Sounds good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.