Default constructor for discrete distribution #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Generates uniformily distributed integers and stores | ||
| /// Returns the minimum potentially generated value. | ||
| result_type BOOST_PREVENT_MACRO_SUBSTITUTION min() const |
There was a problem hiding this comment.
I think the BOOST_PREVENT_MACRO_SUBSTITUTION macro needs to go between the function name and the parentheses. Something like:
result_type min BOOST_PREVENT_MACRO_SUBSTITUTION () const
Add support for the case with first iterator being equal to last iterator in range ctor. Now it behaves like ctor in std::discrete_distribution. Additionaly: now method probabilities() returns correct vector of probabilities.
Class discrete_distribution should generate values of type IntType. Until now it always generated unsigned int values.
jszuppe
force-pushed
the
pr_discrete_distribution
branch
from
02b444d to
56ad192
Compare
|
Changes Unknown when pulling 56ad192 on haahh:pr_discrete_distribution into * on boostorg:develop*. |
|
Looks good, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #612. I've also added
min()andmax()methods and changedboost::compute::discrete_distributionso now it generatesIntTypevalues instead of always generatinguintvalues.