Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see that STL is very fast with the reduction (5x faster compare to our
serial_reduce
used currently inmaster
for reduction on CPUs). I assume it uses SSE/AVX. When reducing vector ofint4_
s instead of vector ofint_
s, the performance ofserial_reduce
becomes almost identical to the performance of STL (for big inputs).New implementation is faster compared to STL for inputs bigger than 2097152 (for reduction with
plus<int>
function).