Restore enabling Large File Support when building directory tools #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until c758552, directory tools were in src/operations.cpp, which defines _FILE_OFFSET_BITS=64 at its very top. This meant that POSIX system calls, such as opendir and readdir, were built with Large File Support enabled. In c758552, directory tools were moved to src/directory.cpp, which didn't define _FILE_OFFSET_BITS=64.
|
I've made a larger fix for this. Thanks for the report. |
|
@Lastique thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for more details.
It might make sense to extract the 43 lines that are then duplicated between
src/directory.cppandsrc/operations.cppto a separate file, but I'll let the maintainers decide.