Fallback to file_directory_information_format for directory iterator #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lastique
added a commit
that referenced
this pull request
Dec 2, 2022
Added ERROR_CALL_NOT_IMPLEMENTED to the list of error codes that are used to permanently downgrade directory querying method. This error code is returned by Wine, which up until version 7.21 did not support FileIdExtdDirectoryRestartInfo and FileFullDirectoryRestartInfo. Further, use non-permanent downgrade on ERROR_INVALID_PARAMETER. Apparently, some mounted filesystems don't implement even the older info classes, such as FileFullDirectoryRestartInfo and FileIdBothDirectoryRestartInfo. These info classes are otherwise supported by the system and work on other filesystems. Lastly, if querying FileIdBothDirectoryRestartInfo fails, fall back to NtQueryDirectoryFile API. Fixes #255. Fixes #266. Closes #267. Possibly related to #261.
iskiselev
commented
Dec 2, 2022
| { | ||
| // Fall back to file_directory_information_format | ||
| filesystem::detail::atomic_store_relaxed(g_extra_data_format, file_directory_information_format); | ||
| return dir_itr_create(imp, dir, opts, params, first_filename, sf, symlink_sf); |
There was a problem hiding this comment.
Attempt to goto into last branch as fallback failed, most probably extra_data / dir_itr_extra_size already has some incorrect data here, have not looked deep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly patch that fixed #266 for me