Skip to content

Create_directories issues fix #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Create_directories issues fix #36

wants to merge 2 commits into from

Conversation

colivi
Copy link

@colivi colivi commented Nov 12, 2016

Hello,

This is a fix for:

Thanks,
Charles

@colivi
Copy link
Author

colivi commented Nov 15, 2016

Hi,
Any chance to have this PR reviewed ? :)

@Beman
Copy link
Contributor

Beman commented Nov 23, 2016

Hi Charles,

I've fixed the problem, making good use of your test cases. I reworked the fix, not because there was necessarily anything wrong with yours, but rather than I wanted to be sure my understanding of the fix was correct.

Thanks,

--Beman

@Beman Beman closed this Nov 23, 2016
@colivi
Copy link
Author

colivi commented Nov 23, 2016

Thanks a lot Beman !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colivi @Beman